resolve comments

quickstart/201-confidential-os-disk/readme.md

@@ -12,7 +12,7 @@ This template deploys an Azure confidential os disk encrypted by platform key.
 | Name | Description |
 |-|-|
 | `location` | (Required) Azure Region in which to deploy these resources.|
-| `name_prefix` | (Optional) Prefix of the resource name. Value defaults to: tftest|
+| `name_prefix` | (Required) Prefix of the resource name.|
 
 ## Example
 

quickstart/201-confidential-os-disk/variables.tf

@@ -5,6 +5,5 @@ variable "location" {
 
 variable "name_prefix" {
   type        = string
-  default     = "tftest"
   description = "Prefix of the resource name"
 }

quickstart/201-confidential-vm/main.tf

@@ -111,7 +111,10 @@ resource "azurerm_linux_virtual_machine" "test" {
   name                = "${var.name_prefix}-vm"
   resource_group_name = azurerm_resource_group.example.name
   location            = azurerm_resource_group.example.location
+  
+  # Available sizes for Confidential VM can be found at: https://docs.microsoft.com/azure/confidential-computing/confidential-vm-overview
   size                = "Standard_DC2as_v5"
+  
   admin_username      = "azureuser"
   network_interface_ids = [
     azurerm_network_interface.example.id,

quickstart/201-confidential-vm/readme.md

@@ -19,8 +19,8 @@ This template deploys an Azure confidential virtual machine with disk encrypted
 | Name | Description |
 |-|-|
 | `location` | (Required) Azure Region in which to deploy these resources.|
+| `name_prefix` | (Required) Prefix of the resource name.|
 | `vm_public_key` | (Required) Public key of the Virtual Machine.|
-| `name_prefix` | (Optional) Prefix of the resource name. Value defaults to: tftest|
 
 ## Example
 

quickstart/201-confidential-vm/variables.tf

@@ -3,13 +3,12 @@ variable "location" {
   description = "Location where resources will be created"
 }
 
+variable "name_prefix" {
+  type        = string
+  description = "Prefix of the resource name"
+}
+
 variable "vm_public_key" {
   type        = string
   description = "Public key of the Virtual Machine"
 }
-
-variable "name_prefix" {
-  type        = string
-  default     = "tftest"
-  description = "Prefix of the resource name"
-}

quickstart/201-confidential-vmss/main.tf

@@ -21,7 +21,10 @@ resource "azurerm_windows_virtual_machine_scale_set" "example" {
   name                 = "${var.name_prefix}-vmss"
   resource_group_name  = azurerm_resource_group.example.name
   location             = azurerm_resource_group.example.location
+
+  # Available skus for Confidential VMSS can be found at: https://docs.microsoft.com/azure/confidential-computing/confidential-vm-overview
   sku                  = "Standard_DC2as_v5"
+  
   instances            = 2
   admin_username       = "adminuser"
   admin_password       = var.admin_password

quickstart/201-confidential-vmss/readme.md

@@ -15,7 +15,7 @@ This template deploys an Azure confidential virtual machine scale set with guest
 |-|-|
 | `admin_password` | (Required) Admin password of the virtual machine scale set.|
 | `location` | (Required) Azure Region in which to deploy these resources.|
-| `name_prefix` | (Optional) Prefix of the resource name. Value defaults to: tftest|
+| `name_prefix` | (Required) Prefix of the resource name.|
 
 ## Example
 

quickstart/201-confidential-vmss/variables.tf

@@ -11,6 +11,5 @@ variable "location" {
 
 variable "name_prefix" {
   type        = string
-  default     = "tftest"
   description = "Prefix of the resource name"
 }