diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/compute.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/compute.tf index 3f7c118f..c8ddab0f 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/compute.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/compute.tf @@ -12,7 +12,7 @@ resource "azurerm_machine_learning_compute_instance" "compute_instance" { location = azurerm_resource_group.default.location machine_learning_workspace_id = azurerm_machine_learning_workspace.default.id virtual_machine_size = "STANDARD_DS2_V2" - subnet_resource_id = "${data.azurerm_subnet.training.id}" + subnet_resource_id = data.azurerm_subnet.training.id depends_on = [ azurerm_private_endpoint.mlw_ple @@ -26,7 +26,7 @@ resource "azurerm_machine_learning_compute_cluster" "compute" { machine_learning_workspace_id = azurerm_machine_learning_workspace.default.id vm_priority = "Dedicated" vm_size = "STANDARD_DS2_V2" - subnet_resource_id = "${data.azurerm_subnet.training.id}" + subnet_resource_id = data.azurerm_subnet.training.id identity { type = "SystemAssigned" diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/network.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/network.tf index 52ed9f13..7c1b7c8f 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/network.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/network.tf @@ -50,7 +50,7 @@ resource "azurerm_network_security_group" "nsg-training" { } resource "azurerm_subnet_network_security_group_association" "nsg-training-link" { - subnet_id = "${data.azurerm_subnet.training.id}" + subnet_id = data.azurerm_subnet.training.id network_security_group_id = azurerm_network_security_group.nsg-training.id } @@ -63,7 +63,7 @@ resource "azurerm_network_security_group" "nsg-aks" { } resource "azurerm_subnet_network_security_group_association" "nsg-aks-link" { - subnet_id = "${data.azurerm_subnet.aks.id}" + subnet_id = data.azurerm_subnet.aks.id network_security_group_id = azurerm_network_security_group.nsg-aks.id } @@ -101,7 +101,7 @@ resource "azurerm_route" "training-BatchRoute" { } resource "azurerm_subnet_route_table_association" "rt-training-link" { - subnet_id = "${data.azurerm_subnet.training.id}" + subnet_id = data.azurerm_subnet.training.id route_table_id = azurerm_route_table.rt-training.id } @@ -121,6 +121,6 @@ resource "azurerm_route" "aks-Internet-Route" { } resource "azurerm_subnet_route_table_association" "rt-aks-link" { - subnet_id = "${data.azurerm_subnet.aks.id}" + subnet_id = data.azurerm_subnet.aks.id route_table_id = azurerm_route_table.rt-aks.id } \ No newline at end of file diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/readme.md b/quickstart/202-machine-learning-moderately-secure-existing-VNet/readme.md index ac2e55f0..18f31e65 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/readme.md +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/readme.md @@ -41,6 +41,11 @@ Please note that this template does not create Azure Private DNS zones. The assu | aks_subnet_name | Name of the existing aks subnet | - | | ml_subnet_name | Name of the existing ML workspace subnet | - | | image_build_compute_name | Name of the compute cluster to be created and configured for building docker images (Azure ML Environments) | image-builder | +| vnet_resource_group_name | Name of the resource group for the existing VNet | - | +| vnet_name | Name of the existing VNet | - | +| training_subnet_name | Name of the existing training subnet | - | +| aks_subnet_name | Name of the existing AKS subnet | - | +| ml_subnet_name | Name of the existing ML workspace subnet | - | | privatelink_api_azureml_ms_resource_id | Resource ID of the existing privatelink.api.azureml.ms private dns zone | - | | privatelink_azurecr_io_resource_id | Resource ID of the existing privatelink.azurecr.io private dns zone | - | | privatelink_notebooks_azure_net_resource_id | Resource ID of the existing privatelink.notebooks.azure.net private dns zone | - | diff --git a/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf b/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf index 6c02bc58..bda44146 100644 --- a/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf +++ b/quickstart/202-machine-learning-moderately-secure-existing-VNet/workspace.tf @@ -70,7 +70,7 @@ resource "azurerm_private_endpoint" "kv_ple" { name = "ple-${var.name}-${var.environment}-kv" location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.default.name - subnet_id = "${data.azurerm_subnet.ml.id}" + subnet_id = data.azurerm_subnet.ml.id private_dns_zone_group { name = "private-dns-zone-group" @@ -89,7 +89,7 @@ resource "azurerm_private_endpoint" "st_ple_blob" { name = "ple-${var.name}-${var.environment}-st-blob" location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.default.name - subnet_id = "${data.azurerm_subnet.ml.id}" + subnet_id = data.azurerm_subnet.ml.id private_dns_zone_group { name = "private-dns-zone-group" @@ -108,7 +108,7 @@ resource "azurerm_private_endpoint" "storage_ple_file" { name = "ple-${var.name}-${var.environment}-st-file" location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.default.name - subnet_id = "${data.azurerm_subnet.ml.id}" + subnet_id = data.azurerm_subnet.ml.id private_dns_zone_group { name = "private-dns-zone-group" @@ -127,7 +127,7 @@ resource "azurerm_private_endpoint" "cr_ple" { name = "ple-${var.name}-${var.environment}-cr" location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.default.name - subnet_id = "${data.azurerm_subnet.ml.id}" + subnet_id = data.azurerm_subnet.ml.id private_dns_zone_group { name = "private-dns-zone-group" @@ -146,7 +146,7 @@ resource "azurerm_private_endpoint" "mlw_ple" { name = "ple-${var.name}-${var.environment}-mlw" location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.default.name - subnet_id = "${data.azurerm_subnet.ml.id}" + subnet_id = data.azurerm_subnet.ml.id private_dns_zone_group { name = "private-dns-zone-group" @@ -172,7 +172,7 @@ resource "azurerm_machine_learning_compute_cluster" "image-builder" { vm_priority = "LowPriority" vm_size = "Standard_DS2_v2" machine_learning_workspace_id = azurerm_machine_learning_workspace.default.id - subnet_resource_id = "${data.azurerm_subnet.training.id}" + subnet_resource_id = data.azurerm_subnet.training.id scale_settings { min_node_count = 0