fixed files on feedback

This commit is contained in:
cshea15 2023-10-03 17:08:46 -04:00
parent 295ee5a644
commit 69a69c4969
3 changed files with 16 additions and 14 deletions

View File

@ -30,7 +30,7 @@ resource "azurerm_public_ip" "pip_azfw" {
resource_group_name = azurerm_resource_group.rg.name resource_group_name = azurerm_resource_group.rg.name
allocation_method = "Static" allocation_method = "Static"
sku = "Standard" sku = "Standard"
zones = [ "1", "2", "3" ] zones = ["1", "2", "3"]
} }
resource "azurerm_storage_account" "sa" { resource "azurerm_storage_account" "sa" {
@ -224,7 +224,7 @@ resource "azurerm_firewall_policy_rule_collection_group" "prcg" {
name = "netRule1" name = "netRule1"
protocols = ["TCP"] protocols = ["TCP"]
source_addresses = ["10.10.1.0/24"] source_addresses = ["10.10.1.0/24"]
destination_addresses = [ "*" ] destination_addresses = ["*"]
destination_ports = ["8000", "8999"] destination_ports = ["8000", "8999"]
} }
} }
@ -254,7 +254,7 @@ resource "azurerm_route_table" "rt" {
name = "azfwDefaultRoute" name = "azfwDefaultRoute"
address_prefix = "0.0.0.0/0" address_prefix = "0.0.0.0/0"
next_hop_type = "VirtualAppliance" next_hop_type = "VirtualAppliance"
next_hop_in_ip_address = "10.10.0.4" next_hop_in_ip_address = azurerm_firewall.fw.ip_configuration[0].private_ip_address
} }
} }

View File

@ -26,16 +26,16 @@ A user-defined route points network traffic from the ServersSubnet subnet throug
- [azurerm_storage_account](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/storage_account) - [azurerm_storage_account](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/storage_account)
- [random_password](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password) - [random_password](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password)
- [random_pet](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/pet) - [random_pet](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/pet)
- [random_string](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/string)} - [random_string](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/string)
## Variables ## Variables
| Name | Description | Default value | | Name | Description | Default value |
|-|-|-| |-|-|-|
| `resource_group_location` | location for your resources | eastus | | `resource_group_location` | Location of the resource group | eastus |
| `firewall_sku_tier` | Sku size for your Firewall and Firewall Policy | Premium | | `firewall_sku_tier` | SKU size for your Firewall and Firewall Policy. Possible values: Standard, Premium | Premium |
| `resource_group_name_prefix` | Prefix for your resource group | rg | | `resource_group_name_prefix` | Prefix of the resource group name that's combined with a random ID so that name is unique in your Azure subscription. | rg |
| `virtual_machine_size` | Sku size for your jump and workload vms | Standard_D2_v3 | | `virtual_machine_size` | SKU size for your jump and workload VMs | Standard_D2_v3 |
| `admin_username` | admin username for the jump and workload vms | azureuser | | `admin_username` | THe admin username for the jump and workload VMs | azureuser |
## Example ## Example

View File

@ -27,5 +27,7 @@ variable "virtual_machine_size" {
} }
variable "admin_username" { variable "admin_username" {
type = string
description = "value of the admin username."
default = "azureuser" default = "azureuser"
} }