From 562d51ac13bd8e641b1ae6bf437a647a52cce53f Mon Sep 17 00:00:00 2001 From: Tom Archer Date: Thu, 9 Mar 2023 11:08:55 -0800 Subject: [PATCH] Edits per Code Review --- quickstart/101-azure-api-management-create/main.tf | 4 ++-- quickstart/101-azure-api-management-create/providers.tf | 2 +- quickstart/101-azure-api-management-create/variables.tf | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/quickstart/101-azure-api-management-create/main.tf b/quickstart/101-azure-api-management-create/main.tf index 87c1f2fd..5b9cd598 100644 --- a/quickstart/101-azure-api-management-create/main.tf +++ b/quickstart/101-azure-api-management-create/main.tf @@ -7,7 +7,7 @@ resource "azurerm_resource_group" "rg" { location = var.resource_group_location } -resource "random_string" "name" { +resource "random_string" "azurerm_api_management_name" { length = 13 lower = true numeric = false @@ -16,7 +16,7 @@ resource "random_string" "name" { } resource "azurerm_api_management" "api" { - name = "apiservice${random_string.name.result}" + name = "apiservice${random_string.azurerm_api_management_name.result}" location = azurerm_resource_group.rg.location resource_group_name = azurerm_resource_group.rg.name publisher_email = var.publisher_email diff --git a/quickstart/101-azure-api-management-create/providers.tf b/quickstart/101-azure-api-management-create/providers.tf index 9db91bd4..c7bd471d 100644 --- a/quickstart/101-azure-api-management-create/providers.tf +++ b/quickstart/101-azure-api-management-create/providers.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">=0.12" + required_version = ">=1.00" required_providers { azurerm = { source = "hashicorp/azurerm" diff --git a/quickstart/101-azure-api-management-create/variables.tf b/quickstart/101-azure-api-management-create/variables.tf index c7fe0f14..08e6455f 100644 --- a/quickstart/101-azure-api-management-create/variables.tf +++ b/quickstart/101-azure-api-management-create/variables.tf @@ -1,9 +1,11 @@ variable "resource_group_location" { + type = string default = "eastus" description = "Location for all resources." } variable "resource_group_name_prefix" { + type = string default = "rg" description = "Prefix of the resource group name that's combined with a random ID so name is unique in your Azure subscription." }