From a8ba805c8bbf3ff7b0c1a74dcf1f78984a4ca245 Mon Sep 17 00:00:00 2001 From: Tom Archer Date: Wed, 29 Sep 2021 06:47:25 -0700 Subject: [PATCH] Implemented changes per review --- quickstart/101-resource-group/main.tf | 6 ++++-- quickstart/101-resource-group/readme.md | 4 ++-- quickstart/101-resource-group/variables.tf | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/quickstart/101-resource-group/main.tf b/quickstart/101-resource-group/main.tf index 808be901..77c1e183 100644 --- a/quickstart/101-resource-group/main.tf +++ b/quickstart/101-resource-group/main.tf @@ -14,9 +14,11 @@ provider "azurerm" { features {} } -resource "random_uuid" "uuid" {} +resource "random_pet" "rg-name" { + prefix = var.resource_group_name_prefix +} resource "azurerm_resource_group" "rg" { - name = "${var.resource_group_name_prefix}-${random_uuid.uuid.result}" + name = random_pet.rg-name.id location = var.resource_group_location } diff --git a/quickstart/101-resource-group/readme.md b/quickstart/101-resource-group/readme.md index b7cfc575..6d27ec6c 100644 --- a/quickstart/101-resource-group/readme.md +++ b/quickstart/101-resource-group/readme.md @@ -11,8 +11,8 @@ This template deploys an Azure resource group with a random name beginning with | Name | Description | |-|-| -| `resource_group_name_prefix` | Prefix of the resource group name that's combined with a random number so name is unique in your Azure subscription. | -| `resource_group_location` | The Azure Region to deploy these resources in | +| `resource_group_name_prefix` | (Optional) Prefix of the resource group name that's combined with a random number so name is unique in your Azure subscription. | +| `resource_group_location` | (Optional) The Azure Region to deploy these resources in | ## Example diff --git a/quickstart/101-resource-group/variables.tf b/quickstart/101-resource-group/variables.tf index 1145b5e2..1790a608 100644 --- a/quickstart/101-resource-group/variables.tf +++ b/quickstart/101-resource-group/variables.tf @@ -1,8 +1,9 @@ variable "resource_group_name_prefix" { default = "rg" - description = "Prefix of the resource group name that's combined with a random number so name is unique in your Azure subscription." + description = "Prefix of the resource group name that's combined with a random ID so name is unique in your Azure subscription." } variable "resource_group_location" { default = "eastus" + description = "Location of the resource group." }