Incorporate review feedback

This commit is contained in:
Paul Jewell
2023-10-16 15:12:22 -04:00
parent 9a5792ab3f
commit 60bba8f8af
5 changed files with 96 additions and 101 deletions

View File

@ -1,26 +1,54 @@
resource "azurerm_resource_group" "example" {
name = "${random_pet.prefix.id}-rg"
location = var.rg_location
resource "random_pet" "rg_name" {
prefix = var.resource_group_name_prefix
}
resource "azurerm_resource_group" "rg" {
name = "${random_pet.rg_name.id}"
location = var.resource_group_location
}
resource "random_string" "azurerm_virtual_network_name" {
length = 13
lower = true
numeric = false
special = false
upper = false
}
resource "azurerm_virtual_network" "example" {
name = "${random_pet.prefix.id}-vnet"
resource_group_name = azurerm_resource_group.example.name
name = coalesce(var.virtual_network_name, "vnet-${random_string.azurerm_virtual_network_name.result}")
resource_group_name = azurerm_resource_group.rg.name
address_space = ["10.0.0.0/16"]
location = azurerm_resource_group.example.location
location = azurerm_resource_group.rg.location
}
resource "random_string" "azurerm_subnet_name" {
length = 13
lower = true
numeric = false
special = false
upper = false
}
resource "azurerm_subnet" "example" {
name = "${random_pet.prefix.id}-subnet"
resource_group_name = azurerm_resource_group.example.name
name = coalesce(var.subnet_name, "subnet-${random_string.azurerm_subnet_name.result}")
resource_group_name = azurerm_resource_group.rg.name
virtual_network_name = azurerm_virtual_network.example.name
address_prefixes = ["10.0.2.0/24"]
}
resource "random_string" "azurerm_amlfs_name" {
length = 13
lower = true
numeric = false
special = false
upper = false
}
resource "azurerm_managed_lustre_file_system" "example" {
name = "${random_pet.prefix.id}"
resource_group_name = azurerm_resource_group.example.name
location = azurerm_resource_group.example.location
name = coalesce(var.amlfs_name, "amlfs-${random_string.azurerm_amlfs_name.result}")
resource_group_name = azurerm_resource_group.rg.name
location = azurerm_resource_group.rg.location
sku_name = var.amlfs_sku_name
subnet_id = azurerm_subnet.example.id
storage_capacity_in_tb = var.amlfs_storage_capacity_in_tb
@ -29,9 +57,4 @@ resource "azurerm_managed_lustre_file_system" "example" {
day_of_week = var.amlfs_maintenance_day_of_week
time_of_day_in_utc = var.amlfs_maintenance_time_of_day
}
}
resource "random_pet" "prefix" {
prefix = var.prefix
length = 1
}