Tips-Of-Mine/gestion-certificats2
2
0
Fork 0
mirror of https://github.com/tips-of-mine/gestion-certificats2.git synced 2025-06-28 09:18:42 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

This commit addresses several issues:

Browse Source 
1.  **`intermediate_cert_name` unique constraint violation**:
    When creating a perimeter, the intermediate certificate name (`intermediate_cert_name`) stored in the `functional_perimeters` table was always `"intermediate.cert.pem"`. This caused a duplicate error if a unique constraint existed on this column.
    *   Fixed in `PerimeterController.php` by using `$perimeterName . "_intermediate.cert.pem"` as the value for `intermediate_cert_name`, ensuring uniqueness. The physical file name remains `intermediate.cert.pem` in the perimeter's subdirectory.

2.  **`Undefined variable $userRole` warning**:
    On the page listing perimeters (`app/src/Views/perimeters/index.php`), the `$userRole` variable was not defined by the controller.
    *   Fixed in `PerimeterController.php` (method `index()`) by initializing `$userRole = $this->authService->getUserRole();`.

3.  **SQL error `Unknown column 'common_name'` during initialization**:
    During the application initialization process (if no user or root certificate exists), an attempt to insert into the `certificates` table included a `common_name` column that does not exist.
    *   Fixed in `app/public/index.php` by removing the `common_name` column and its value from the insert query for the root certificate.

These corrections improve the robustness of perimeter creation and make the application initialization process more reliable.
This commit is contained in:
google-labs-jules[bot]
2025-06-16 11:36:47 +00:00
parent 6b54a44c6e
commit d4516e87ae
4 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/public/index.php
View File

@ -142,8 +142,8 @@ if ($userCount === 0 || !$rootCertExists) {
$expirationDate = $expirationTimestamp ? date('Y-m-d H:i:s', $expirationTimestamp) : (new DateTime('+10 years'))->format('Y-m-d H:i:s');
// Enregistrer le certificat root dans la base de données
$stmt = $dbInstance->prepare("INSERT INTO certificates (name, type, common_name, expiration_date) VALUES (?, ?, ?, ?)");
$stmt->execute(['ca.cert.pem', 'root', $_SESSION['init_root_domain'], $expirationDate]);
$stmt = $dbInstance->prepare("INSERT INTO certificates (name, type, expiration_date) VALUES (?, ?, ?)");
$stmt->execute(['ca.cert.pem', 'root', $expirationDate]);
} else {
echo "<p style=\"color: red;\">Erreur lors de la création du certificat Root CA. Veuillez vérifier les logs PHP et Docker.</p>";
echo "<pre>" . htmlspecialchars($output) . "</pre>";

13
app/src/Controllers/PerimeterController.php
View File

@ -51,6 +51,7 @@ class PerimeterController
$errorMessage = $_SESSION['error'] ?? null;
unset($_SESSION['error']);
$userRole = $this->authService->getUserRole(); // Définir $userRole
require_once APP_ROOT_DIR . '/src/Views/perimeters/index.php';
}
@ -163,11 +164,12 @@ class PerimeterController
if (strpos($output, "Certificat Intermédiaire CA pour '$perimeterName' créé") !== false) {
// Enregistrer le périmètre dans la base de données
$stmt = $this->db->prepare("INSERT INTO functional_perimeters (name, intermediate_cert_name) VALUES (?, ?)");
$intermediateCertFileName = "intermediate.cert.pem"; // Nom générique du fichier pour l'intermédiaire
$intermediateCertFileName = $perimeterName . "_intermediate.cert.pem"; // Nom unique pour la BDD
$stmt->execute([$perimeterName, $intermediateCertFileName]);
$perimeterId = $this->db->lastInsertId();
// Enregistrer le certificat intermédiaire dans la table des certificats
// Le nom de fichier sur le disque reste "intermediate.cert.pem" dans son dossier de périmètre.
$fullCertPath = INTERMEDIATE_CA_PATH_BASE . "/{$perimeterName}/certs/intermediate.cert.pem";
$expirationDate = (new \DateTime('+5 years'))->format('Y-m-d H:i:s'); // Valeur par défaut
if (file_exists($fullCertPath)) {
@ -178,6 +180,7 @@ class PerimeterController
}
}
// Utiliser $intermediateCertFileName (qui est maintenant unique) pour l'enregistrement en BDD dans la table 'certificates'
$stmt = $this->db->prepare("INSERT INTO certificates (name, type, functional_perimeter_id, expiration_date) VALUES (?, ?, ?, ?)");
$stmt->execute([$intermediateCertFileName, 'intermediate', $perimeterId, $expirationDate]);
@ -185,7 +188,13 @@ class PerimeterController
$this->logService->log('info', "Périmètre fonctionnel '$perimeterName' créé avec succès et certificat intermédiaire généré.", $userId, $ipAddress);
$_SESSION['success'] = $this->langService->__('perimeter_create_success');
} else {
$_SESSION['error'] = $this->langService->__('perimeter_create_error', ['output' => htmlspecialchars($output)]);
// Check for specific error message
$specificErrorMessage = "Erreur : Le répertoire pour le périmètre '$perimeterName' existe déjà.";
if (strpos($output, $specificErrorMessage) !== false) {
$_SESSION['error'] = $this->langService->__('perimeter_create_error_directory_exists', ['perimeterName' => $perimeterName]);
} else {
$_SESSION['error'] = $this->langService->__('perimeter_create_error', ['output' => htmlspecialchars($output)]);
}
$this->logService->log('error', "Échec création périmètre '$perimeterName': $output", $userId, $ipAddress);
}